Skip to content

Don't wirelessly link an ItemStack's component to a live player#909

Merged
imreallybadatnames merged 1 commit into
DaFuqs:1.21.1-fabricfrom
SaphireLattice:fix/1.21.1-fabric/concealing-oil-mutation
Jun 15, 2026
Merged

Don't wirelessly link an ItemStack's component to a live player#909
imreallybadatnames merged 1 commit into
DaFuqs:1.21.1-fabricfrom
SaphireLattice:fix/1.21.1-fabric/concealing-oil-mutation

Conversation

@SaphireLattice

@SaphireLattice SaphireLattice commented Jun 15, 2026

Copy link
Copy Markdown

Per neoforge docs (but it's a minecraft's own class, they just documented some about it):

MobEffectInstances are mutable. If you need a copy, call new MobEffectInstance(oldInstance).

Stops the item stack from having an effect updated by the player's effect ticking down. Or whatever might be going on in the depths of minecraft codebase.

Also behaved really oddly (crash potentially?) when you tried to store it in some mods' special item containers

@imreallybadatnames imreallybadatnames left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

satisfactory

@imreallybadatnames imreallybadatnames merged commit 0d1f13e into DaFuqs:1.21.1-fabric Jun 15, 2026
2 checks passed
@SaphireLattice SaphireLattice deleted the fix/1.21.1-fabric/concealing-oil-mutation branch June 15, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants